replace ramda with welshman/lib #508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09e44f3 to
9cc0a0e
Compare
staab
reviewed
Dec 17, 2024
There was a problem hiding this comment.
- I've released a new version of welshman with
pluckin it, go ahead and use that instead of map/prop. Alsospecandcomplementcan be useful to replacewhereEq, but that's optional - Prop is now parameterizable, so you can avoid type assertions
- I've added a linting rule for triple equals, be sure to rebase and lint
src/app/shared/Channel.svelte
Outdated
| const stickToBottom = async () => { | ||
| const lastMessage = pluck("created_at", groupedMessages).reduce(max, 0) | ||
| const lastMessage = max(groupedMessages.map(prop("created_at")) as number[]) |
There was a problem hiding this comment.
Prefer lambdas over type assertions. Prop is probably a bad idea.
9cc0a0e to
4b16e25
Compare
- type definitions
4b16e25 to
043c2dc
Compare
staab
reviewed
Dec 18, 2024
|
Merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#372
Replaced most of ramda utilities with either welshman/lib or standard JS functions.
takeWhile might deserve its own implementation in welshman/lib.