add tooltip in qrcode of login bunker #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasnt able to run master BTW |
|
Looks good, thanks! What problems did you run into running it? |
|
Oh, if it was dev then that makes sense, it's on an in-development version of welshman right now. |
It was more like not knowing how to connect, i was exploring the platform for the first time i wasnt sure if i needed to copy something from the nsec app and add to coracle or vice versa. but it was late at night |
|
Got it, bunker connections are kind of arcane still. The qr code is a nostrconnect:// string, and the bunker url nsec.app provides can be pasted into the input. But everyone could do a better job explaining that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was learning about the app and nostr
And when i tried to connect the coracle with nsec i was a little bit lost
coracle was showing a qr code and nsec was showing a input field, at the time i didnt saw the cursor changing to copy when i hovered the qr code
I think adding a tooltip in the qr code will help in the UX