Update smoke tests to start/stop on Windows. #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clintonio
approved these changes
May 15, 2017
Contributor
Clintonio
left a comment
There was a problem hiding this comment.
I believe the issue with zombie JVMs from Capsule is an issue with Java and Windows process handling. Essentially if you kill the JVM process (on Windows ) it doesn't properly run the cleanup hooks so it can't kill the sub processes.
Contributor
|
Also approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the smoke tests to run on Windows. However, Corda on Windows runs as a subprocess of the Capsule's JVM. This means that killing the process only removes the Capsule and leave Corda itself running. I think that this is only fixable via the Capsule unless Java can also destroy all subprocesses.