ENT-14136 - Cross-provider key rotation #8046
Draft
+101
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
DO NOT MERGE FOR NOW! |
filipesoliveira
commented
Dec 4, 2025
core/src/main/kotlin/net/corda/core/contracts/CrossProviderKeyRotationProof.kt
Outdated
Show resolved
Hide resolved
filipesoliveira
commented
Dec 4, 2025
core/src/main/kotlin/net/corda/core/contracts/CrossProviderKeyRotationProof.kt
Outdated
Show resolved
Hide resolved
vlajos
reviewed
Dec 4, 2025
core/src/main/kotlin/net/corda/core/transactions/TransactionWithSignatures.kt
Outdated
Show resolved
Hide resolved
1c8cec8 to
7212cbf
Compare
vlajos
reviewed
Dec 8, 2025
| proof.signature, | ||
| proof.publicKeyNew.encoded | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
Is this class working for longer proof chains?
I think if the chains have gaps, it still treats all supplied proofs as valid.
Contributor
Author
There was a problem hiding this comment.
Good catch. For a proof chain to be valid, it must end with the signing key, and all proofs in the metadata must be properly linked. I have updated the code.
…roof chains must include the key that generated the signature and must not contain any unrelated proofs.
70d0433 to
9be2c4f
Compare
9be2c4f to
4a3698a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.