Added vault query as tokenizable service. #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsasari
requested changes
Jun 27, 2017
| override fun call() { | ||
| serviceHub.vaultService.unconsumedStates<Cash.State>().filter { true } | ||
| waitForLedgerCommit(SecureHash.zeroHash) | ||
| } |
Contributor
There was a problem hiding this comment.
I'd take this opportunity to delete this test
| private class VaultQueryFlow : FlowLogic<List<StateAndRef<ContractState>>>() { | ||
| @Suspendable | ||
| override fun call(): List<StateAndRef<ContractState>> { | ||
| return serviceHub.vaultQueryService.queryBy<ContractState>().states |
Contributor
There was a problem hiding this comment.
Missing waitForLedgerCommit
shamsasari
reviewed
Jun 27, 2017
| val stx = node1.services.signInitialTransaction(ptx) | ||
|
|
||
| node1.registerFlowFactory(VaultQueryFlow::class) { | ||
| WaitingFlows.Committer(it) |
Contributor
There was a problem hiding this comment.
You don't need to do the map
shamsasari
approved these changes
Jun 27, 2017
kchalkias
pushed a commit
that referenced
this pull request
Jun 27, 2017
* Added vault query as tokenizable service. * Add JUnit test to test access of vault query service within a flow. * Improved JUnit test to correctly validate tokenizable behaviour. * Minor cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.