Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@joeyberkovitz
Copy link

No description provided.

T-jegou and others added 3 commits June 24, 2025 08:57
The Redfish Chassis schema (v1.27.0) defines the NetworkAdapters property
as an optional link to a collection of network adapters physically located
in the chassis. It is perfectly valid for this property to be omitted when
no adapters are present.

However, the current implementation of (*Chassis).NetworkAdapters() calls
ListReferencedNetworkAdapter even when the link is empty, potentially
resulting in 404 errors or misleading failures on otherwise valid systems.

This patch introduces an early return when the networkAdapters link is
not defined, aligning the behavior with other optional properties such as
Power(), Thermal(), and PCIeSlots().

This is particularly relevant for minimal chassis configurations like
backplanes or storage components (e.g., ChassisType: "Component" or "Module"),
which often appear in the Chassis collection but do not expose network
hardware.

Reference: https://redfish.dmtf.org/schemas/v1/Chassis.v1_27_0.json
To allow insecure (unverified TLS) connections, we need to set a flag
allowing it. When using the default http client, or if a supplied client
has not been fully configured, the struct containing this flag is not
initialized and set to nil in the http client transport.

This makes sure the config property is initialized if we are configured
to set the flag to avoid nil pointer errors.

Signed-off-by: Sean McGinnis <[email protected]>
@joeyberkovitz joeyberkovitz merged commit 3fe4172 into coreweave:main Jul 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants