plugin/bind: allow binding particularly link-local addresses (using a scope/zone) #6551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also as a side effect allows using hostnames Signed-off-by: Till Riedel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
I split off this PR as part of #6547 as it introduces new behaviour. It particularly allows binding link local addresses where a scope/zone is needed (typically the interface name). As it uses ResolveIPAddr hostnames are also passed through. It seems that the downstream bind code will accept this as well
2. Which issues (if any) are related?
This started of as #6536
3. Which documentation changes (if any) need to be made?
I tried to change the documentation
4. Does this introduce a backward incompatible change or deprecation?
This widens the acceptable input. I would doubt that workflows relied on the error behavior, but it is not impossible.