Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Return RcodeServerFailure when DNS64 has no next plugin #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperQ merged 1 commit into from
Apr 9, 2024
Merged

Return RcodeServerFailure when DNS64 has no next plugin #6590

SuperQ merged 1 commit into from
Apr 9, 2024

Conversation

@jmbaur
Copy link
Contributor

@jmbaur jmbaur commented Apr 8, 2024 •
edited
Loading

1. Why is this pull request needed and what does it do?

If using a coredns config with only the dns64 plugin specified, the Next plugin that dns64 will attempt to call will be nil, resulting in a nil pointer dereference. We should return an error instead of crashing.

server # [   42.192968] coredns[836]: panic: runtime error: invalid memory address or nil pointer dereference
server # [   42.195715] coredns[836]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xc30dc7]
server # [   42.198407] coredns[836]: goroutine 70 [running]:
server # [   42.200304] coredns[836]: github.com/coredns/coredns/plugin/dns64.(*DNS64).ServeDNS(0xc0001d4720, {0x2943198, 0xc0001d4ed0}, {0x294c3f8, 0xc000013ed8}, 0xc0004bbd40)
server # [   42.202514] coredns[836]:   github.com/coredns/coredns/plugin/dns64/dns64.go:47 +0x287
server # [   42.206366] coredns[836]: github.com/coredns/coredns/core/dnsserver.(*Server).ServeDNS(0xc000751480, {0x2943198, 0xc0001d4ed0}, {0x294c3f8, 0xc000013ed8}, 0xc0004bbd40)
server # [   42.208629] coredns[836]:   github.com/coredns/coredns/core/dnsserver/server.go:364 +0x826
server # [   42.209917] coredns[836]: github.com/coredns/coredns/core/dnsserver.(*Server).ServePacket.func1({0x294d9f8, 0xc000751680}, 0xc0004bbd40)
server # [   42.211190] coredns[836]:   github.com/coredns/coredns/core/dnsserver/server.go:178 +0x8e
server # [   42.212123] coredns[836]: github.com/miekg/dns.HandlerFunc.ServeDNS(0xc000145c00?, {0x294d9f8?, 0xc000751680?}, 0xc0004bbd40?)
server # [   42.213307] coredns[836]:   github.com/miekg/[email protected]/server.go:37 +0x29
server # [   42.214177] coredns[836]: github.com/miekg/dns.(*Server).serveDNS(0xc0000fb200, {0xc000145c00, 0x36, 0x200}, 0xc000751680)
server # [   42.215303] coredns[836]:   github.com/miekg/[email protected]/server.go:659 +0x42a
server # [   42.216110] coredns[836]: github.com/miekg/dns.(*Server).serveUDPPacket(0xc0000fb200, 0xc000643fd0, {0xc000145c00, 0x36, 0x200}, {0x294a0c0, 0xc00076ddd0}, 0xc0007a7040, {0x0, 0x0})
server # [   42.217697] coredns[836]:   github.com/miekg/[email protected]/server.go:603 +0x1a5
server # [   42.218505] coredns[836]: created by github.com/miekg/dns.(*Server).serveUDP in goroutine 65
server # [   42.219385] coredns[836]:   github.com/miekg/[email protected]/server.go:533 +0x405

2. Which issues (if any) are related?

None

3. Which documentation changes (if any) need to be made?

None

4. Does this introduce a backward incompatible change or deprecation?

No

@jmbaur jmbaur requested a review from SuperQ as a code owner April 8, 2024 02:24
chrisohaver
chrisohaver reviewed Apr 8, 2024
View reviewed changes
@jmbaur
Return RcodeServerFailure when DNS64 has no next plugin
0613f77 
If using a coredns config with only the dns64 plugin specified, the
`Next` plugin that dns64 will attempt to call will be nil, resulting in
a nil pointer dereference. We should return an error instead of
crashing.

Signed-off-by: Jared Baur <[email protected]>
@SuperQ SuperQ requested a review from chrisohaver April 9, 2024 07:35
@codecov
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.23%. Comparing base (93c57b6) to head (0613f77).
Report is 1165 commits behind head on master.

Files Patch % Lines
plugin/dns64/dns64.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6590      +/-   ##
==========================================
+ Coverage   55.70%   59.23%   +3.53%     
==========================================
  Files         224      252      +28     
  Lines       10016    13471    +3455     
==========================================
+ Hits         5579     7979    +2400     
- Misses       3978     4900     +922     
- Partials      459      592     +133

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuperQ SuperQ merged commit 6706ee8 into coredns:master Apr 9, 2024
@jmbaur jmbaur deleted the dns64-next branch April 9, 2024 09:10
@BrewTestBot BrewTestBot mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperQ SuperQ SuperQ approved these changes

@chrisohaver chrisohaver Awaiting requested review from chrisohaver

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmbaur @SuperQ @chrisohaver