core: set cache-control max-age as integer, not float #6764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM thanks! Can you sign the commit to the DCO check passes? Thanks! |
As specified in rfc2616, the max-age is an integer. Setting a float might make the header get ignored in some cases.
ba59fa5 to
b5cb5a7
Compare
Contributor
Author
|
replaced with signed commit, hope everything checks out! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When CoreDNS is used as a dns-over-https server, it sets cache control headers.
However, the max-age is set as a float, instead of an integer as specified in RFC 2616.
How
This PR truncates the float into an integer, using
uint32which is also what the dnsutil is using.Why
Setting the max-age as a float can make the value get ignored in some cases, such as when fronted by a caching CDN.