fix: reload close channel #6916
Open
+26
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Kuzko <[email protected]>
Signed-off-by: Sergii Kuzko <[email protected]>
Signed-off-by: Sergii Kuzko <[email protected]>
Signed-off-by: Sergii Kuzko <[email protected]>
Signed-off-by: Sergii Kuzko <[email protected]>
be29904 to
ceb6c89
Compare
Signed-off-by: Sergii Kuzko <[email protected]>
Signed-off-by: Sergii Kuzko <[email protected]>
|
I cant put my finger on the significance of these changes. Palpably, what problem do these changes resolve? |
I don't see how this code changes the behavior. It looks like go routines were closed before, and they are still closed after these changes. Can you show how in the previous code that the go routines were not closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
This pull request introduces improvements to the reload functionality of CoreDNS. It refines the logic for periodically checking for changes in the Corefile configuration and enhances the shutdown procedure for the reload goroutine. Specifically, it:
chan struct{}to signal the reload routine to stop.onInstanceStartuphook.2. Which issues (if any) are related?
This PR addresses the need for a more robust and synchronized reload mechanism in CoreDNS, improving overall stability.
The problem remains #6646 #6645
3. Which documentation changes (if any) need to be made?
No documentation changes are needed.
4. Does this introduce a backward incompatible change or deprecation?
No, this pull request does not introduce any backward incompatible changes or deprecations. It enhances existing functionality while maintaining compatibility with current configurations.