bugfix prometheus/pprof port not released on upgrade #6074
Merged
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can this be tested in CI? |
Author
|
or maybe I should create PR on caddy, to add OnUpgrade -- to attach callback for plugins that have custom listen port that should be shutted down before upgrade? |
|
Could not review pull request. It may be too large, or contain no reviewable changes. |
Author
|
rip the pull bot is resetting the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
metrics (prometheus) and pprof plugin does not release listening port when doing coredns upgrade
so need to listen to SIGUSR2 signal, then shutdown the server so next fork (upgraded binary) will not have an error.
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?
no