plugin/trace: migrate dd-trace-go v1 to v2 #7466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade dd-trace-go dependency to v2.2.2 - Separate Zipkin and DataDog code paths for better maintainability - Add proper tracer shutdown through OnShutdown() - Replace deprecated opentracer.New() with direct tracer.Start() - Added tests Signed-off-by: Ville Vesilehto <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7466 +/- ##
==========================================
+ Coverage 55.70% 59.92% +4.22%
==========================================
Files 224 274 +50
Lines 10016 18135 +8119
==========================================
+ Hits 5579 10867 +5288
- Misses 3978 6632 +2654
- Partials 459 636 +177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yongtang
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Migrates the DataDog tracing integration
dd-trace-gofrom v1 to v2. Version 1 will be deprecated by the end of this year. See docs here.Changes:
dd-trace-godependency to v2.2.2OnShutdown()opentracer.New()withtracer.Start()Validated with a DataDog test account that spans are being spawned properly, with the proper tags.
2. Which issues (if any) are related?
Fixes #7372.
3. Which documentation changes (if any) need to be made?
None - configuration syntax and behavior remain identical for users.
4. Does this introduce a backward incompatible change or deprecation?
This change is fully backwards compatible:
coredns.io@name,coredns.io@type, etc.)