plugin/nomad: Add a Nomad plugin #7467
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7467 +/- ##
==========================================
+ Coverage 55.70% 61.98% +6.28%
==========================================
Files 224 278 +54
Lines 10016 18542 +8526
==========================================
+ Hits 5579 11493 +5914
- Misses 3978 6356 +2378
- Partials 459 693 +234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c753b5 to
ad00dc5
Compare
plugin/nomad/README.md
Outdated
| cache | ||
| errors | ||
| nomad { | ||
| zone service.nomad |
There was a problem hiding this comment.
Looks like the zone option is missing from the Syntax section, Although...
In most other plugins the zone is configured as an option before the plugin block, as in ...
nomad service.nomad {
address http://127.0.0.1:4646 http://127.0.0.2:4646 http://127.0.0.3:4646
ttl 10
}
It's not a crucial difference, but it would make it more consistent with the syntax of other plugins that specify a zone.
ad00dc5 to
f533097
Compare
|
@thevilledev @chrisohaver All valid feedback. Should be fixed now. |
f533097 to
466fc52
Compare
thevilledev
left a comment
There was a problem hiding this comment.
Minor comments from my side
Signed-off-by: Olli Janatuinen <[email protected]>
466fc52 to
46cdaad
Compare
@thevilledev Those are fixed now as well. |
1. Why is this pull request needed and what does it do?
This is replacement for #5833 to add a
nomadplugin, takes improvements from https://github.com/ituoga/coredns-nomad and handle feedback which that original PR received.2. Which issues (if any) are related?
#5829
3. Which documentation changes (if any) need to be made?
The plugin README.md included.
4. Does this introduce a backward incompatible change or deprecation?
No