core: propagate HTTP request context in DoH #7491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously DNS-over-HTTPS used context.Background() instead of the HTTP request context, breaking timeout propagation and cancellation. With this fix, the original HTTP request context is passed forward. Adds a test for validation. Update documentation about context use in plugin development. Signed-off-by: Ville Vesilehto <[email protected]>
3a639e5 to
47b149b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7491 +/- ##
==========================================
+ Coverage 55.70% 60.07% +4.36%
==========================================
Files 224 274 +50
Lines 10016 18147 +8131
==========================================
+ Hits 5579 10901 +5322
- Misses 3978 6610 +2632
- Partials 459 636 +177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yongtang
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
DNS-over-HTTPS implementation used
context.Background()instead of the HTTP request context when callingServeDNS(). This broke timeout propagation and cancellation, causing DNS processing to continue even after HTTP clients disconnected or timed out. With this change, the original HTTP request context is used as the base context.Add a test for validation. These tests also cover how the HTTP request metadata can be accessed through the context in plugins. If you run the test against
masterbranch you'll see that the test fails:Update documentation about context use in plugin development.
2. Which issues (if any) are related?
None found. However, the broken timeout/cancellation behavior may have caused all kinds of issues. This has been in the codebase since #1619 or CoreDNS v1.1.3 (May 2018).
3. Which documentation changes (if any) need to be made?
I added a note to
plugin.mdabout what kind of transport related information is available through the context.4. Does this introduce a backward incompatible change or deprecation?
No breaking changes. DNS processing now properly respects HTTP request timeouts and cancellation.