plugin/transfer: fix goroutine leak on axfr err #7516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
e2e tests fail until #7515 is merged in. Will rebase this once it's in. |
0476b28 to
4869d1d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7516 +/- ##
==========================================
+ Coverage 55.70% 61.77% +6.07%
==========================================
Files 224 274 +50
Lines 10016 18233 +8217
==========================================
+ Hits 5579 11264 +5685
- Misses 3978 6307 +2329
- Partials 459 662 +203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Lets check the test coverage. We should remain at least on the same level. |
Fixes a goroutine leak in zone transfers: when a client disconnects mid-transfer, the server could return without draining the producer channel, leaving the producer goroutine blocked on a small buffer. The writer goroutine only sends an error after channel is closed. At this point "pchan" is fully drained, in the new implementation, so nothing to drain on error anyway. Signed-off-by: Ville Vesilehto <[email protected]>
437e603 to
477e1b3
Compare
Collaborator
Author
|
Much better. :-) |
yongtang
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Fixes a goroutine leak in zone transfers: when a client disconnects (or
tr.Outerrors) mid-transfer, the server could return without draining the producer channel, leaving the producer goroutine blocked on a small buffer. This change drains the producer channel on client error, ensuring the producer completes and preventing leaks.Adds a unit test to verify the producer finishes after a simulated write failure. These tests fail against
master. Increases test coverage forplugin/transferfrom 67.5% to 70.7%.2. Which issues (if any) are related?
#6548
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
No. The server now drains the producer channel to completion instead of leaking a goroutine.