Update prometheus version #7533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates prometheus version as PR coredns#7522 failed Signed-off-by: Yong Tang <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7533 +/- ##
==========================================
+ Coverage 55.70% 61.76% +6.06%
==========================================
Files 224 274 +50
Lines 10016 18233 +8217
==========================================
+ Hits 5579 11262 +5683
- Misses 3978 6308 +2330
- Partials 459 663 +204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 9, 2025
dec6728 to
5e1df94
Compare
thevilledev
approved these changes
Sep 10, 2025
Collaborator
thevilledev
left a comment
There was a problem hiding this comment.
LGTM! Here's the breaking change for posterity: prometheus/client_golang@v1.23.0...v1.23.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates prometheus version as PR #7522 failed
Fix on CI see: coredns/ci#165
Signed-off-by: Yong Tang [email protected]