fix(dnstap): add bounds for plugin args #7557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate dnstap writebuffer (MiB) and queue (x10k) args. Reject non-integers and out-of-range values with clear errors. Updated plugin documentation and tests. Signed-off-by: Ville Vesilehto <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7557 +/- ##
==========================================
+ Coverage 55.70% 62.16% +6.46%
==========================================
Files 224 274 +50
Lines 10016 18308 +8292
==========================================
+ Hits 5579 11381 +5802
- Misses 3978 6261 +2283
- Partials 459 666 +207 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yongtang
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Validate dnstap writebuffer (MiB) and queue (x10k) args. Reject non-integers and out-of-range values with clear errors. Updated plugin documentation and tests.
Should fix the following OSS-Fuzz findings:
Verified locally that the reproducer didn't work after the patch. Should clear out automatically after this PR is merged in.
2. Which issues (if any) are related?
None.
3. Which documentation changes (if any) need to be made?
Added additional documentation on TCP max buffer size and queue capacity for the plugin.
4. Does this introduce a backward incompatible change or deprecation?
The sizes are quite generous I think. Should not be an incompatible change.