Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Filippo125
Copy link
Contributor

@Filippo125 Filippo125 commented Nov 13, 2025

1. Why is this pull request needed and what does it do?

Add support for DoH3

2. Which issues (if any) are related?

Resolve issue #5539

3. Which documentation changes (if any) need to be made?

Update main Readme.md with example for DoH3

4. Does this introduce a backward incompatible change or deprecation?

No, the https3 server (DoH3) has been implemented separately from the https2 server (DoH).

Signed-off-by: Filippo <[email protected]>
Copy link
Collaborator

@thevilledev thevilledev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution!

Only had the chance for a brief glance, but could you please add tests? Feel free to use core/dnsserver and test for inspiration from other transport protocols & e2e tests.

Add new prometheus counter for https3

Signed-off-by: Filippo <[email protected]>
@Filippo125
Copy link
Contributor Author

Thank you for your comment. I found an error in promethueus counter, fix adding specific counter for https3. I also add a specific test

Copy link
Collaborator

@thevilledev thevilledev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thevilledev thevilledev merged commit d3e13fe into coredns:master Nov 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants