-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add basic support for DoH3 #7677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Filippo <[email protected]>
Signed-off-by: Filippo <[email protected]>
Signed-off-by: Filippo <[email protected]>
ec02ed4 to
1822516
Compare
Signed-off-by: Filippo <[email protected]>
thevilledev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your contribution!
Only had the chance for a brief glance, but could you please add tests? Feel free to use core/dnsserver and test for inspiration from other transport protocols & e2e tests.
Add new prometheus counter for https3 Signed-off-by: Filippo <[email protected]>
|
Thank you for your comment. I found an error in promethueus counter, fix adding specific counter for https3. I also add a specific test |
thevilledev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
1. Why is this pull request needed and what does it do?
Add support for DoH3
2. Which issues (if any) are related?
Resolve issue #5539
3. Which documentation changes (if any) need to be made?
Update main Readme.md with example for DoH3
4. Does this introduce a backward incompatible change or deprecation?
No, the https3 server (DoH3) has been implemented separately from the https2 server (DoH).