Thanks to visit codestin.com
Credit goes to github.com

Skip to content

plugin/pkg/uniq: fix data race with sync.RWMutex #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thevilledev merged 1 commit into from
Nov 24, 2025
+27 −5
Merged

plugin/pkg/uniq: fix data race with sync.RWMutex #7707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions plugin/pkg/uniq/uniq.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@
// identical events will only be processed once.
package uniq

import "sync"

// U keeps track of item to be done.
type U struct {
u map[string]item
mu sync.RWMutex
u map[string]item
}

type item struct {
Expand All @@ -13,23 +16,42 @@ type item struct {
}

// New returns a new initialized U.
func New() U { return U{u: make(map[string]item)} }
func New() *U { return &U{u: make(map[string]item)} }

// Set sets function f in U under key. If the key already exists it is not overwritten.
func (u U) Set(key string, f func() error) {
func (u *U) Set(key string, f func() error) {
// Read lock for check
u.mu.RLock()
_, exists := u.u[key]
u.mu.RUnlock()

if exists {
return
}

// Write lock for modification
u.mu.Lock()
defer u.mu.Unlock()

// Double-check to avoid TOCTOU
if _, ok := u.u[key]; ok {
return
}
u.u[key] = item{todo, f}
}

// Unset removes the key.
func (u U) Unset(key string) {
func (u *U) Unset(key string) {
u.mu.Lock()
defer u.mu.Unlock()
delete(u.u, key)
}

// ForEach iterates over u and executes f for each element that is 'todo' and sets it to 'done'.
func (u U) ForEach() error {
func (u *U) ForEach() error {
u.mu.Lock()
defer u.mu.Unlock()

for k, v := range u.u {
if v.state == todo {
v.f()
Expand Down