feat(forward): add max connect attempts knob #7722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2025
In coredns#7704 we fixed a busy loop error by coupling upstream connection errors with a shared counter. This counter collides with healthchecks and the max_fails parameter, and it might have unintended side effects. This change replaces that implementation with an optional per-request counter. It is limited by the new max_connect_attempts parameter. By default this is set to 0, maintaining the legacy behaviour and thus keeping it backwards-compatible. Updates tests and plugin docs. Signed-off-by: Ville Vesilehto <[email protected]>
71ce4fc to
74fd2f1
Compare
yongtang
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Based on the discussion from #7704 (review) with @rdrozhdzh
In #7704 we fixed a busy loop error by coupling upstream connection errors with a shared counter called
fails. This counter collides with healthchecks and themax_failsparameter, and it might have unintended side effects.This change replaces that implementation with an optional per-request counter. It is limited by the new
max_connect_attemptsparameter. By default this is set to 0, maintaining the legacy behaviour and thus keeping it backwards-compatible. Updates tests and plugin docs.2. Which issues (if any) are related?
See #7723 for potential next steps to change the default behaviour.
3. Which documentation changes (if any) need to be made?
Plugin docs updated.
4. Does this introduce a backward incompatible change or deprecation?
Once merged, the default behaviour is back to where it was. The default value is set to 0 and using this new parameter is opt-in.