fix: kubernetes plugin logging #7727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevilledev
approved these changes
Nov 27, 2025
Collaborator
thevilledev
left a comment
There was a problem hiding this comment.
LGTM
Seems to be the case since CoreDNS v1.9.4 e0dead4
The plugin dropped the actual error message from the log, so the log becomes completely useless. Before: ``` [ERROR] plugin/kubernetes: error Failed to watch ``` After: ``` [ERROR] plugin/kubernetes: Failed to watch: failed to list *v1.Namespace: Get "https://10.96.0.1:443/api/v1/namespaces?limit=500&resourceVersion=0": tls: failed to parse certificate from server: x509: SAN dNSName is malformed ``` Signed-off-by: Andrey Smirnov <[email protected]>
f206559 to
e6b2aa8
Compare
Contributor
Author
|
updated fixing the linter warning (removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin dropped the actual error message from the log, so the log becomes completely useless.
Before:
After:
1. Why is this pull request needed and what does it do?
Fixes a bug which makes troubleshooting next to impossible.
2. Which issues (if any) are related?
None, but due to Go 1.25.2 changes to strict SAN validation, CoreDNS might fail to access Kubernetes API on version 1.13.1.
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
Nope.