Revert "only create PTR records for endpoints with hostname defined" #7194
Conversation
…oredns#6898)" This reverts commit f4f0d55. Signed-off-by: Adrian Moisey <[email protected]>
6424ba9 to
23888d2
Compare
|
@chrisohaver ptal I still think we should answer these questions, and probably update the DNS spec, and implement to match. Even if the answer to the questions are "do what we used to do", we should document them clearly. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7194 +/- ##
==========================================
+ Coverage 55.70% 57.83% +2.13%
==========================================
Files 224 270 +46
Lines 10016 17378 +7362
==========================================
+ Hits 5579 10051 +4472
- Misses 3978 6716 +2738
- Partials 459 611 +152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think we should revert. |
|
IMO, “what we used to do” made sense, and tbh despite having executed the fix, I don’t fully understand the reasoning behind the hostname-only fix and why it was needed. (That’s not to say I don’t think there was a good reason for it - I’m just admitting that I executed the fix without fully understanding reasoning) |
Reverts #6898
See discussion in #7177