Added SetProxyOptions function for forward plugin
#7229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paramoshka <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7229 +/- ##
==========================================
+ Coverage 55.70% 56.55% +0.85%
==========================================
Files 224 270 +46
Lines 10016 17381 +7365
==========================================
+ Hits 5579 9830 +4251
- Misses 3978 6960 +2982
- Partials 459 591 +132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chrisohaver
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
This PR adds a SetProxyOptions function for the forward plugin. During the discussion of the previous Pull Request #7105 we came to the conclusion that the dynamicforward plugin should be moved to external plugins under a different name kubeforward, which we did [https://github.com/deckhouse/coredns-kubeforward], we also submitted a PR to add this plugin to external plugins.
But to fully realize the functionality of our plugin, we need an interface to pass proxy parameters to the forward plugin.
2. Which issues (if any) are related?
No.
3. Which documentation changes (if any) need to be made?
No.
4. Does this introduce a backward incompatible change or deprecation?
No.