fix(plugin/secondary): make transfer property mandatory #7249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wafuwafu13 <[email protected]>
Signed-off-by: wafuwafu13 <[email protected]>
wafuwafu13
commented
Apr 12, 2025
| }, | ||
| { | ||
| `secondary example.org { | ||
| transferr from 127.0.0.1 |
Contributor
Author
There was a problem hiding this comment.
Intentionally made a typo.
chrisohaver
approved these changes
Apr 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7249 +/- ##
==========================================
+ Coverage 55.70% 56.60% +0.90%
==========================================
Files 224 270 +46
Lines 10016 17413 +7397
==========================================
+ Hits 5579 9856 +4277
- Misses 3978 6965 +2987
- Partials 459 592 +133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
coredns/plugin/secondary/setup_test.go
Line 18 in 52b3172
coredns/plugin/secondary/setup.go
Line 86 in 52b3172
2. Which issues (if any) are related?
None
3. Which documentation changes (if any) need to be made?
Already documented
https://coredns.io/plugins/secondary/
4. Does this introduce a backward incompatible change or deprecation?
No. This change enforces that secondary zones must have a
transfer fromproperty, which was already an implicit requirement and is documented in the plugin documentation.The change makes this requirement explicit in the code.