fix(plugin/bind): remove zone for link-local IPv4 #7295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7295 +/- ##
==========================================
+ Coverage 55.70% 57.64% +1.93%
==========================================
Files 224 273 +49
Lines 10016 17892 +7876
==========================================
+ Hits 5579 10313 +4734
- Misses 3978 6968 +2990
- Partials 459 611 +152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@mmickan Would you mind fix the DCO issue? https://github.com/coredns/coredns/pull/7295/checks?check_run_id=42175895880 |
ecc528e to
4d33af0
Compare
This fixes a bug introduced in coredns#6547 which resulted in the zone being added to IPv4 addresses. This bug results in a failure to start when binding to an interface with a link-local IPv4 address assigned to it, with the following error: $ ./coredns -conf=/etc/coredns/Corefile maxprocs: Leaving GOMAXPROCS=4: CPU quota undefined lookup 169.254.1.1%dummy0: no such host Signed-off-by: Mark Mickan <[email protected]>
4d33af0 to
03ca6bc
Compare
Contributor
Author
|
Hi @yongtang , The DCO check is now passing and I've rebased on master while I was at it. Thanks, |
yongtang
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
On a host with an IPv4 link-local address assigned to an interface that CoreDNS is configured to bind to, this happens:
This PR fixes an incorrect test for an IPv6 address so it only adds the zone to IPv6 addresses, never to IPv4.
2. Which issues (if any) are related?
#6547 introduced the bug.
3. Which documentation changes (if any) need to be made?
None, this makes it work the way the documentation already says it works. 😃
4. Does this introduce a backward incompatible change or deprecation?
No.