feat: enable plugins via environment during build #7310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colden Cullen <[email protected]>
Signed-off-by: Colden Cullen <[email protected]>
Contributor
Author
I'm willing to bet this is a timeout given the roundness of that time, is this a normal flake or should I take a look at fixing something? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7310 +/- ##
==========================================
+ Coverage 55.70% 57.61% +1.91%
==========================================
Files 224 273 +49
Lines 10016 17892 +7876
==========================================
+ Hits 5579 10308 +4729
- Misses 3978 6971 +2993
- Partials 459 613 +154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
A recurring issue yes. I filed an issue about it now and will have a look later this week: #7311 Re-ran the failing tests and all green now. :) |
yongtang
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
This change will make it easier to automate builds using external plugins. For example, if I'm building my own image using
coredns-abcandcoredns-defplugins, I can just setCOREDNS_PLUGINS=abs:github.com/whatever/coredns-abc,def:github.com/something/coredns-defwhen I initiate my build.2. Which issues (if any) are related?
None.
3. Which documentation changes (if any) need to be made?
Docs changes are not strictly necessary, but I've added a note to the README on how to use this feature.
4. Does this introduce a backward incompatible change or deprecation?
Nope!