fix(metrics): preserve request size from plugins #7313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7313 +/- ##
==========================================
+ Coverage 55.70% 57.77% +2.07%
==========================================
Files 224 273 +49
Lines 10016 17912 +7896
==========================================
+ Hits 5579 10348 +4769
- Misses 3978 6952 +2974
- Partials 459 612 +153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
37eef4f to
dfb7866
Compare
The rewrite plugin modifies DNS messages, affecting the request size observed in the coredns_dns_request_size_bytes metric. This change captures the original request size before any plugins can modify it. It adds a functional options pattern to Report() to pass this information while maintaining API compatibility. Tests have been added to verify the fix prevents rewrite from affecting the request size metrics. Docs included. Signed-off-by: Ville Vesilehto <[email protected]>
dfb7866 to
2f9b7c9
Compare
yongtang
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
The rewrite plugin modifies DNS messages, affecting the request size observed in the
coredns_dns_request_size_bytesmetric.This change captures the original request size before any plugins can modify it. It adds a functional options pattern to
Report()to pass this information while maintaining API compatibility.Tests have been added to verify the fix prevents rewrite from affecting the request size metrics. If the same test is run against
masterit fails as follows:Prometheus utilities used in the test file brought in a new dependency to
go.mod.Includes a small docs update.
2. Which issues (if any) are related?
Fixes #7162
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
No. After this correction has been merged, users utilising these request size metrics might notice a difference if rewrite plugin is used.