fix(caddyfile): guard snippet import cycles #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cycle guard for Caddyfile snippet imports. Track snippet expansions with a hard cap (1000) and error on trivial self-imports in snippet bodies to prevent infinite recursion. Add tests for snippet self-import failure. Signed-off-by: Ville Vesilehto <[email protected]>
64e47b7 to
768b8db
Compare
Author
yongtang
approved these changes
Sep 19, 2025
This was referenced Sep 19, 2025
jdamick
pushed a commit
to jdamick/caddy
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cycle guard for Caddyfile snippet imports. Track snippet expansions with a hard cap (1000) and error on trivial self-imports in snippet bodies to prevent infinite recursion.
Add tests for snippet self-import, to validate the newly added failure state. Run the
TestSnippetImportCycletest againstmasterbranch and you will see it times out:Originally found in OSS-Fuzz issue #42486385 while fuzzing CoreDNS.
Once merged, could we publish a new release and bump the dependency in CoreDNS?