fix(caddyfile): prevent NextBlock() infinite loop #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NextBlock() now checks the result of Next() and stops when EOF is reached, ensuring the cursor always makes forward progress. This eliminates a potential infinite loop when a block is unclosed. Added a test to assert an unclosed block cannot cause NextBlock() to return the same token all over again. Signed-off-by: Ville Vesilehto <[email protected]>
Author
|
hey @yongtang, would it be possible to get some help with the review? Relates to coredns/coredns#7571. Caddy tests pass locally and I'm checking that the CoreDNS tests pass too, with a temporary |
yongtang
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextBlock()now checks the result ofNext()and stops when EOF is reached. This ensures the cursor always makes forward progress, eliminating a potential infinite loop when a block is unclosed.Added a test to assert an unclosed block cannot cause
NextBlock()to return the same token all over again.This relates to an OSS-Fuzz finding #446778634.