Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Conversation

@krnowak
Copy link
Collaborator

@krnowak krnowak commented Nov 27, 2015

Adds a new category of config called "paths" which is intended to
allow the user to configure various paths. At the moment, it supports
one - the data directory. By setting this, you can control where image
files are stored without having to give a CLI argument.

This is based on #1192.

I will need it for configuring default stage1 directory.

@krnowak
Copy link
Collaborator Author

krnowak commented Nov 27, 2015

I decided to postpone renaming the --dir flag to --data for now. This can be done in a separate PR.

@krnowak
Copy link
Collaborator Author

krnowak commented Nov 27, 2015

TBD: Update the CHANGELOG, after the 0.12.0 is released.

@jonboulle jonboulle added this to the v0.13.0 milestone Dec 1, 2015
@alban
Copy link
Member

alban commented Dec 1, 2015

LGTM

Just a nitpick

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the first sentence in this file is:

The data directory is normally /var/lib/rkt but rkt can be requested to use another directory via the --dir command line argument.

Can this updated? Maybe something like:

The data directory is normally /var/lib/rkt, unless configured otherwise. + link to configuration.md

@krnowak
Copy link
Collaborator Author

krnowak commented Dec 4, 2015

Rebased to master and updated the documentation.

@krnowak krnowak force-pushed the krnowak/data-dir branch 2 times, most recently from 678d14a to 46807a6 Compare December 4, 2015 13:31
@alban
Copy link
Member

alban commented Dec 4, 2015

needs to be rebased again.

Karl Beecher and others added 3 commits December 7, 2015 11:23
Adds a new category of config called "paths" which is intended to
allow the user to configure various paths. At the moment, it supports
one - the data directory. By setting this, you can control where image
files are stored without having to give a CLI argument.
@krnowak
Copy link
Collaborator Author

krnowak commented Dec 7, 2015

Rebased.

@alban
Copy link
Member

alban commented Dec 7, 2015

LGTM

alban added a commit that referenced this pull request Dec 7, 2015
config: Make the data directory configurable
@alban alban merged commit a969044 into rkt:master Dec 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants