Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Makes the data directory configurable #1192

Closed
wants to merge 1 commit into from
Closed

Makes the data directory configurable #1192

wants to merge 1 commit into from

Conversation

@kbeecher
Copy link
Contributor

Adds a new category of config called "directories" which is intended to
allow the user to configure various paths. At the moment, it supports
one - the data directory. By setting this, you can control where image
files are stored without having to give a CLI argument.

@kbeecher kbeecher force-pushed the kbeecher/data-dir branch 2 times, most recently from 595b3e4 to eafaa85 Compare July 28, 2015 08:56
krnowak
krnowak reviewed Jul 28, 2015
View reviewed changes
rkt/config/directories.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if config.Directories.DataDir is empty before setting it to dirs.Data. If it is not, then an error should be returned. See auth.go:111. This is to avoid when somebody puts two config files of directories kind in system configuration directory and specifies data dir in both.

@krnowak
Copy link
Collaborator

krnowak commented Jul 28, 2015

Reviewed, there are some issues to be fixed. Also, I see no unit tests. :P

@kbeecher kbeecher force-pushed the kbeecher/data-dir branch 5 times, most recently from e61facc to 64791f0 Compare July 29, 2015 21:02
alban
alban reviewed Jul 30, 2015
View reviewed changes
rkt/run.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tempDir is "" not defined if getDataDir() != "". Before, store.NewStore was never called with an empty string.

@kbeecher kbeecher force-pushed the kbeecher/data-dir branch from 64791f0 to 0e0fce9 Compare July 30, 2015 14:32
krnowak
krnowak reviewed Jul 31, 2015
View reviewed changes
Documentation/configuration.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in providede.

@krnowak
Copy link
Collaborator

krnowak commented Jul 31, 2015

I just started thinking if we should rename the kind from "directories" to "paths". Sounds more generic and might come in handy if we will want to configure a location of some specific file, instead of a directory.

What do you think?

@kbeecher kbeecher force-pushed the kbeecher/data-dir branch 2 times, most recently from ba236a8 to 368c1ea Compare August 4, 2015 11:33
@kbeecher
Copy link
Contributor Author

kbeecher commented Aug 4, 2015

@krnowak Sounds fair to me. Changed in the latest version.

@kbeecher kbeecher force-pushed the kbeecher/data-dir branch from 368c1ea to bf5ee54 Compare August 5, 2015 08:52
@kbeecher kbeecher mentioned this pull request Aug 14, 2015
Merged
@kbeecher
Copy link
Contributor Author

@krnowak Can this be merged... the error in the Semaphor build is unrelated to my code?

@iaguis
Copy link
Member

iaguis commented Aug 14, 2015

Can you do the change suggested in #1271 (comment) in this PR? Thanks!

@kbeecher
Copy link
Contributor Author

@iaguis @krnowak Done!

krnowak
krnowak reviewed Aug 19, 2015
View reviewed changes
Documentation/configuration.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's paths.d, now.

@krnowak
Copy link
Collaborator

krnowak commented Aug 19, 2015

I'm a bit worried about --dir parameter renaming to --data. The former name was really bad, but now it's breaking change. I was wondering if we shouldn't keep --dir as a deprecated option, which would be kept until 0.9 is released and removed afterwards.

On the other hand, this option is probably not widely used anyway...

@alban, @iaguis: What do you think?

@krnowak
Copy link
Collaborator

krnowak commented Aug 19, 2015

We need to reach out to kubernetes and ask them if they are using this parameter.

cc @yifan-gu

Makes the data directory configurable
4105524 
Adds a new category of config called "directories" which is intended to
allow the user to configure various paths. At the moment, it supports
one - the data directory. By setting this, you can control where image
files are stored without having to give a CLI argument.
@yifan-gu
Copy link
Contributor

I am using it https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/rkt/rkt.go#L56
But it's ok if we have a release on this, I can update the rkt version requirement in kubelet.

jonboulle
jonboulle reviewed Aug 19, 2015
View reviewed changes
rkt/run.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data dir

@krnowak krnowak mentioned this pull request Nov 27, 2015
Merged
@krnowak
Copy link
Collaborator

krnowak commented Nov 27, 2015

Closing in favor of #1806.

@krnowak krnowak closed this Nov 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@krnowak krnowak

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kbeecher @krnowak @iaguis @yifan-gu @alban @steveej @jonboulle