Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fzipi
Copy link
Member

@fzipi fzipi commented Nov 3, 2024

This is a test.

Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the add-quantum-table branch 3 times, most recently from 56ec2be to 88749f3 Compare November 4, 2024 12:25
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the add-quantum-table branch 7 times, most recently from cd4bcbb to af851bd Compare November 4, 2024 14:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi force-pushed the add-quantum-table branch 2 times, most recently from 844ab59 to e68d44a Compare November 4, 2024 14:47
Signed-off-by: Felipe Zipitria <[email protected]>
@M4tteoP
Copy link
Member

M4tteoP commented Nov 18, 2024

Following #3927, it could be nice to have this table inside another expandable content before the diff. With a final message that could look something like this:

⚠️ Quantitative testing detected new false positives
📝 Total false positives: 408 -> 10407

Run details

Time to run tests: ms
Total tests:
False positives:

False positives per rule:

key value
920220 198
920221 198
932235 4
932270 2
932380 2
933160 1
942100 1
942230 1
942360 1
Diff details

3c3
<   "falsePositives": 408,
---
>   "falsePositives": 10407,
10c10
<     "933160": 1,
---
>     "933160": 10000,
15c15
<   "totalTime": 7355236987
---
>   "totalTime": 9614894260

@dune73
Copy link
Member

dune73 commented Nov 18, 2024

I quite like @M4tteoP's idea.

@fzipi
Copy link
Member Author

fzipi commented Nov 18, 2024

Beautiful.

@fzipi
Copy link
Member Author

fzipi commented Nov 26, 2024

@M4tteoP This was superseded? I'm lost now 😄

@M4tteoP
Copy link
Member

M4tteoP commented Nov 26, 2024

This was superseded?

Not entirely, this PR introduces the details of the quantitative run as a table, which is a nice enhancement to have in another expandable content for every run

@fzipi
Copy link
Member Author

fzipi commented Jun 21, 2025

@M4tteoP Can you help me push this one? I completely forgot about it, and could use some help 😅

@M4tteoP
Copy link
Member

M4tteoP commented Jun 22, 2025

Yes!

@fzipi
Copy link
Member Author

fzipi commented Aug 1, 2025

Ping @M4tteoP !

@M4tteoP
Copy link
Member

M4tteoP commented Sep 16, 2025

thanks @azurit, I'll prioritize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants