Fix/extend tests, move Seconds into separate module #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
signumfunction for TimeSpec to match the multiplication. AlsoSecondsis moved into a separate module, so that the various functions can be re-exported withSecondstype. I had to exportnormalizeands2nsbut people doing complicated things with the TimeSpec type will probably need them.I also extended the tests a lot, amazingly they all pass. They don't pass if you change
arbitrarySizedIntegraltoarbitrary, due to overflow errors. Maybe there should be a warning somewhere about the silent overflow behavior.And I added a Bounded instance for TimeSpec / Seconds, hopefully it's correct.