Only use ubuntu runners supported by github, avoid using containers when practical, tidy up other workflows #1544
Conversation
4348401 to
2bf1423
Compare
2bf1423 to
8552e94
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub workflow configurations to use officially supported Ubuntu runners, avoid container usage when possible, and improve workflow consistency and performance.
- Renames and updates job names to better reflect their purpose
- Replaces container-based setups with matrix-based runner selection and introduces parallel builds
- Standardizes installation, configuration, and test steps across multiple workflow files
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ubuntu_tests.yml | Updates job names, matrix OS versions, and steps |
| .github/workflows/msvc.yml, msvc-analyzer.yml, macos.yml | Adds parallel build flags and minor naming updates |
| .github/workflows/lint.yml, clang-tidy.yml | Minor naming adjustments for clarity |
| .github/workflows/compiler-sanitizers.yml, codeql.yml | Introduces parallel build options |
| .github/workflows/cmake.yaml, amazon_linux_tests.yml | Applies similar updates with matrix-based runner usage |
| .github/workflows/actions/ubuntu-build-deps/action.yml | Updates to step naming and package installation |
Comments suppressed due to low confidence (2)
.github/workflows/actions/ubuntu-build-deps/action.yml:17
- Consider quoting the variable in the condition (e.g. "if [ "${{inputs.SUDO}}" = true ]") to prevent issues related to word splitting or empty values.
if [ ${{inputs.SUDO}} = true ]
.github/workflows/cmake.yaml:32
- Ensure that the change from '${{github.workspace}}/build' to 'build' is intentional and consistent across workflows for managing build directories.
cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
|
@eakraly this looks reasonable to me, are you ok with it? Apart from the fact that lint job is failing and that the PR mixes some renaming/cleanup with the change of containers but I can leave with it. |
Looks ok. Most of it is just naming. |
|
@jonesmz do you think you could resolve the conflicts? |
|
Sure, will take a look. Give me a few days. |
587e0de to
509efe9
Compare
509efe9 to
d33d527
Compare
…hen practical, tidy up other workflows
d33d527 to
d23aa69
Compare
| - name: Install Dependencies | ||
| uses: ./.github/workflows/actions/ubuntu-build-deps | ||
| with: | ||
| SUDO: true |
| @@ -1,53 +1,47 @@ | |||
| name: macOS | |||
| name: MacOS | |||
There was a problem hiding this comment.
This is incorrect
The formal name is macOS https://www.apple.com/os/macos/
No description provided.