change port identifiers to use uint16_t #1752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab7cd62 to
42bd9c7
Compare
eakraly
reviewed
Sep 21, 2025
| init_socket(&udp_fd, local_addr, *local_port, remote_addr); | ||
|
|
||
| ret = stunclient_send(&buf, udp_fd, local_addr, local_port, remote_addr, change_ip, change_port, padding, -1); | ||
| ret = stunclient_send(&buf, udp_fd, local_addr, (uint16_t *)local_port, remote_addr, change_ip, change_port, padding, |
There was a problem hiding this comment.
Why not change the argument to the function instead?
There was a problem hiding this comment.
these all fall under the same issue - init_socket uses local_port as a pseudo-boolean, where it is treated as a port in the range [0, USHRT_MAX), but as a negation of a path when < 0.
the port has to be passed as an integer through some functions to preserve this meaning.
eakraly
reviewed
Sep 21, 2025
| init_socket(&udp_fd, local_addr, *local_port, remote_addr); | ||
|
|
||
| ret = stunclient_send(&buf, udp_fd, local_addr, local_port, remote_addr, change_ip, change_port, padding, -1); | ||
| ret = stunclient_send(&buf, udp_fd, local_addr, (uint16_t *)local_port, remote_addr, change_ip, change_port, padding, |
There was a problem hiding this comment.
Same... instead of casting should change the function argument
eakraly
reviewed
Sep 21, 2025
| } | ||
|
|
||
| addr_set_port(&real_local_addr, response_port); | ||
| addr_set_port(&real_local_addr, (uint16_t)response_port); |
There was a problem hiding this comment.
change the type of the argument of addr_set_port
eakraly
requested changes
Sep 21, 2025
42bd9c7 to
1dcda65
Compare
1dcda65 to
240c486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the ideas originally developed in this pr by @WHYHD