Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: client queryS being called without an id ( query options ) #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

fix: client queryS being called without an id ( query options ) #3583

wants to merge 6 commits into from
+228 −172

Conversation

@rezk2ll
Copy link
Contributor

@rezk2ll rezk2ll commented Oct 24, 2025

what's changed

  • added the getDriveSettingQuery for io.cozy.drive.settings queries
  • used getDriveSettingQuery in saving sort choice
  • fixed switch context view using rogue query ( without an id )

@rezk2ll rezk2ll requested a review from Crash-- October 24, 2025 12:37
@rezk2ll rezk2ll force-pushed the fix/client-queries branch from 32c508f to 8465bc6 Compare October 24, 2025 12:43
@zatteo
Copy link
Member

zatteo commented Oct 24, 2025

I do not understand, when do we use io.cozy.files.settings and io.cozy.drive.settings?

@rezk2ll
Copy link
Contributor Author

rezk2ll commented Oct 24, 2025

I do not understand, when do we use io.cozy.files.settings and io.cozy.drive.settings?

in ViewSwitcherContextProvider we use io.cozy.files.settings and in useFolderSort we use io.cozy.drive.settings.

i think it's best to mutualize them and use io.cozy.drive.settings, i think it's a great oppurtunity to do so since i started this refacto

@zatteo
Copy link
Member

zatteo commented Oct 24, 2025

I do not understand, when do we use io.cozy.files.settings and io.cozy.drive.settings?

in ViewSwitcherContextProvider we use io.cozy.files.settings and in useFolderSort we use io.cozy.drive.settings.

i think it's best to mutualize them and use io.cozy.drive.settings, i think it's a great oppurtunity to do so since i started this refacto

Do we have two "Drive settings" doctype? I did not remember about io.cozy.files.settings

@rezk2ll
Copy link
Contributor Author

rezk2ll commented Oct 24, 2025 •
edited
Loading

I do not understand, when do we use io.cozy.files.settings and io.cozy.drive.settings?

in ViewSwitcherContextProvider we use io.cozy.files.settings and in useFolderSort we use io.cozy.drive.settings.
i think it's best to mutualize them and use io.cozy.drive.settings, i think it's a great oppurtunity to do so since i started this refacto

Do we have two "Drive settings" doctype? I did not remember about io.cozy.files.settings

As we discussed, the io.cozy.files.settings is the wrong way of storing the drive application-related settings, and it should live in io.cozy.{app}.settings

@bundlemon
Copy link

bundlemon bot commented Oct 26, 2025 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ public/static/js/public.(hash).js
 111.16KB (-12B -0.01%) -
✅ static/js/main.(hash).js
 147.52KB (-25B -0.02%) -
Unchanged files (19)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 958.28KB -
✅ static/js/cozy.(hash).js
 870.22KB -
✅ public/static/js/(chunkId).(hash).js
 870.09KB -
✅ public/static/js/cozy.(hash).js
 725.64KB -
✅ (hash).js
 336.11KB -
✅ public/(hash).js
 336.11KB -
✅ services/qualificationMigration.js
 283.49KB -
✅ services/dacc.js
 263.19KB -
✅ public/static/js/lib-react.(hash).js
 39.24KB -
✅ static/js/lib-react.(hash).js
 39.24KB -
✅ public/static/css/cozy.(hash).css
 33.38KB -
✅ static/css/cozy.(hash).css
 33.38KB -
✅ public/static/js/lib-router.(hash).js
 21.86KB -
✅ static/js/lib-router.(hash).js
 21.86KB -
✅ static/css/main.(hash).css
 16.77KB -
✅ public/static/css/public.(hash).css
 6.46KB -
✅ manifest.webapp
 3.04KB -
✅ index.html
 690B -
✅ assets/manifest.json
 185B -

Total files change -37B 0%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 6.75MB (-37B 0%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.17MB -
✅ **/*.css
 129.68KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@rezk2ll rezk2ll marked this pull request as draft October 26, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF-Cozy JF-Cozy Awaiting requested review from JF-Cozy JF-Cozy is a code owner

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

@lethemanh lethemanh Awaiting requested review from lethemanh lethemanh is a code owner

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

@lenhanphung lenhanphung Awaiting requested review from lenhanphung lenhanphung is a code owner

@Crash-- Crash-- Awaiting requested review from Crash--

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rezk2ll @zatteo