Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Now use jsx for colored folder #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

fix: Now use jsx for colored folder #3609

merged 1 commit into from
Nov 7, 2025

Conversation

@doubleface
Copy link
Contributor

@doubleface doubleface commented Nov 6, 2025

image image

Using css mask caused leaking mask visible when in dark mode. And I could not find a solution working for dark mode and light mode.

Now using jsx to draw the folders with a gradient which will render the same way with every themes.

@doubleface doubleface force-pushed the feat/ColoredFolderGradient branch from 3c78ec7 to bb49332 Compare November 6, 2025 15:23
@doubleface doubleface force-pushed the fix/folderCustomizerIcons branch from 48bbdfe to 513de4b Compare November 6, 2025 15:23
@bundlemon
Copy link

bundlemon bot commented Nov 6, 2025 •
edited
Loading

BundleMon

Files updated (6)
Status Path Size Limits
✅ static/js/main.(hash).js
 157.6KB (+554B +0.34%) -
✅ public/static/js/public.(hash).js
 124.41KB (+363B +0.29%) -
✅ static/css/main.(hash).css
 16.9KB (-114B -0.65%) -
✅ public/static/css/public.(hash).css
 6.47KB (-232B -3.38%) -
✅ static/js/cozy.(hash).js
 906.13KB (-305B -0.03%) -
✅ public/static/js/cozy.(hash).js
 771.05KB (-346B -0.04%) -
Unchanged files (15)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 971.02KB -
✅ public/static/js/(chunkId).(hash).js
 905.5KB -
✅ (hash).js
 336.11KB -
✅ public/(hash).js
 336.11KB -
✅ services/qualificationMigration.js
 281.49KB -
✅ services/dacc.js
 261.47KB -
✅ public/static/js/lib-react.(hash).js
 39.24KB -
✅ static/js/lib-react.(hash).js
 39.24KB -
✅ public/static/css/cozy.(hash).css
 33.65KB -
✅ static/css/cozy.(hash).css
 33.65KB -
✅ public/static/js/lib-router.(hash).js
 21.86KB -
✅ static/js/lib-router.(hash).js
 21.86KB -
✅ manifest.webapp
 3.04KB -
✅ index.html
 688B -
✅ assets/manifest.json
 185B -

Total files change -81B 0%

Groups updated (2)
Status Path Size Limits
✅ **/*.js
 6.92MB (+266B 0%) -
✅ **/*.css
 127.51KB (-346B -0.26%) -
Unchanged groups (1)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.19MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@doubleface doubleface force-pushed the fix/folderCustomizerIcons branch from 513de4b to cdca5df Compare November 7, 2025 10:53
@doubleface doubleface force-pushed the feat/ColoredFolderGradient branch from bb49332 to 2a47fd3 Compare November 7, 2025 11:18
Base automatically changed from fix/folderCustomizerIcons to master November 7, 2025 11:22
fix: Now use jsx for colored folder
7ec598b 
Using css mask caused leaking mask visible when in dark mode. And I
could not find a solution working for dark mode and light mode.

Now using jsx to draw the folders with a gradient which will render
the same way with every themes.
@doubleface doubleface force-pushed the feat/ColoredFolderGradient branch from 2a47fd3 to 7ec598b Compare November 7, 2025 11:23
@doubleface doubleface merged commit fa7ce84 into master Nov 7, 2025
4 checks passed
@doubleface doubleface deleted the feat/ColoredFolderGradient branch November 7, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rezk2ll rezk2ll rezk2ll approved these changes

@JF-Cozy JF-Cozy Awaiting requested review from JF-Cozy JF-Cozy is a code owner

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

@lethemanh lethemanh Awaiting requested review from lethemanh lethemanh is a code owner

@lenhanphung lenhanphung Awaiting requested review from lenhanphung lenhanphung is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doubleface @rezk2ll