Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Increase arp cache size #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Increase arp cache size #63

merged 1 commit into from
Jun 25, 2025

Conversation

@kvaps
Copy link
Member

@kvaps kvaps commented Jun 23, 2025 •
edited by coderabbitai bot
Loading

Signed-off-by: Andrei Kvapil [email protected]

Summary by CodeRabbit

  • New Features
    • Added configuration options to set IPv4 neighbor table thresholds in the Talos cluster setup.

@kvaps
Increase arp cache size
4104fdf 
Signed-off-by: Andrei Kvapil <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Jun 23, 2025 •
edited
Loading

Walkthrough

A new sysctls section was added to the Talos cluster template under the machine configuration, specifying three IPv4 neighbor table garbage collection thresholds. No other logic, error handling, or control flow was changed.

Changes

File Summary
charts/cozystack/templates/_helpers.tpl Added sysctls section with three IPv4 neighbor table GC thresholds to Talos machine configuration.

Poem

In cozy stacks where configs dwell,
A rabbit tweaks the kernel well.
Three thresholds set, so neat and spry—
For neighbor tables reaching high.
With sysctls now in the mix,
Our network’s ready for new tricks!
🐇🛠️

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 23, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
charts/cozystack/templates/_helpers.tpl (1)

16-19: Parameterize sysctl thresholds in values.yaml for flexibility
Hard-coding these GC thresholds reduces configurability and maintainability. Consider moving them into values.yaml and templating via toYaml:

# values.yaml
 sysctls:
+  net.ipv4.neigh.default.gc_thresh1: 4096
+  net.ipv4.neigh.default.gc_thresh2: 8192
+  net.ipv4.neigh.default.gc_thresh3: 16384
# charts/cozystack/templates/_helpers.tpl
 sysctls:
-  net.ipv4.neigh.default.gc_thresh1: "4096"
-  net.ipv4.neigh.default.gc_thresh2: "8192"
-  net.ipv4.neigh.default.gc_thresh3: "16384"
+  {{- toYaml .Values.sysctls | nindent 2 }}

This keeps defaults in one place and allows overrides.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c172fb and 4104fdf.

⛔ Files ignored due to path filters (1)
  • pkg/generated/presets.go is excluded by !**/generated/**
📒 Files selected for processing (1)
  • charts/cozystack/templates/_helpers.tpl (1 hunks)
🔇 Additional comments (1)
charts/cozystack/templates/_helpers.tpl (1)

16-19: ```shell
#!/bin/bash

Show sysctls lines with surrounding context in the helper template

grep -n 'sysctls:' -C3 charts/cozystack/templates/_helpers.tpl


</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@kvaps kvaps merged commit 0a276f2 into main Jun 25, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kvaps