Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ENH] improve methods #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2022
Merged

[ENH] improve methods #98

merged 4 commits into from
Dec 16, 2022

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Dec 16, 2022 •
edited
Loading

closes #67

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 16, 2022 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 11.60%.

Quality metrics Before After Change
Complexity 0.68 ⭐ 3.83 ⭐ 3.15 👎
Method Length 48.25 ⭐ 61.80 🙂 13.55 👎
Working memory 4.63 ⭐ 6.53 🙂 1.90 👎
Quality 83.80% ⭐ 72.20% 🙂 -11.60% 👎
Other metrics Before After Change
Lines 56 92 36
Changed files Quality Before Quality After Quality Change
bidsmreye/methods.py 80.15% ⭐ 62.07% 🙂 -18.08% 👎
tests/test_methods.py 94.02% ⭐ 92.46% ⭐ -1.56% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/methods.py methods 6 ⭐ 155 😞 8 🙂 60.73% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 16, 2022 •
edited
Loading

Codecov Report

Merging #98 (a1c850b) into main (786bd34) will increase coverage by 64.84%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##            main      #98       +/-   ##
==========================================
+ Coverage   0.00%   64.84%   +64.84%     
==========================================
  Files          7        7               
  Lines        536      549       +13     
  Branches       0       84       +84     
==========================================
+ Hits           0      356      +356     
+ Misses       536      161      -375     
- Partials       0       32       +32
Flag Coverage Δ
tests 64.84% <93.75%> (+64.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bidsmreye/methods.py 90.90% <93.75%> (+90.90%) ⬆️
bidsmreye/generalize.py 45.23% <0.00%> (+45.23%) ⬆️
bidsmreye/prepare_data.py 50.00% <0.00%> (+50.00%) ⬆️
bidsmreye/bidsmreye.py 59.70% <0.00%> (+59.70%) ⬆️
bidsmreye/utils.py 70.56% <0.00%> (+70.56%) ⬆️
bidsmreye/download.py 80.39% <0.00%> (+80.39%) ⬆️
bidsmreye/__init__.py 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau merged commit bc66e09 into cpp-lln-lab:main Dec 16, 2022
@Remi-Gau Remi-Gau deleted the methods branch December 16, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create autogenerated methods

1 participant

@Remi-Gau