Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ontime release #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2024
Merged

ontime release #694

merged 3 commits into from
Jan 10, 2024

Conversation

@cpvalente
Copy link
Owner

@cpvalente cpvalente commented Jan 5, 2024 •
edited
Loading

TODO: still missing the version bump,
pending on the decision on whether to ship google-sheets as is

Summary by CodeRabbit

  • Documentation
    • Updated the project setup process to include a new step for building packages with a specific build command before docker image creation.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2024 •
edited
Loading

Important

Auto Review Skipped

Review was skipped due to path filters

Walkthrough

The modification updates the project's setup instructions to include a new step where developers must run the command pnpm build:localdocker to build necessary packages. This step is essential and must be completed before proceeding to build the project's Docker image, ensuring all local dependencies are correctly compiled and available for the Docker environment.

Changes

File Change Summary
DEVELOPMENT.md Added a step to run pnpm build:localdocker before building the Docker image during project setup.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Jan 5, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 068ec80 and 4a6df35.
Files selected for processing (1)
  • DEVELOPMENT.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • DEVELOPMENT.md

@cpvalente cpvalente changed the title docs: document new docker script ontime release Jan 5, 2024
@cpvalente cpvalente marked this pull request as draft January 5, 2024 20:33
@alex-Arc alex-Arc marked this pull request as ready for review January 10, 2024 14:12
@cpvalente cpvalente merged commit 71092af into master Jan 10, 2024
@cpvalente cpvalente deleted the release-preparation branch January 10, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpvalente @alex-Arc