Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 12, 2021. It is now read-only.

Conversation

@praveenkumar
Copy link
Member

No description provided.

Copy link

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a link to the upstream PR

Makefile Outdated
BUILD_DIR ?= out

ORG := github.com/code-ready
REPOPATH ?= $(ORG)/goodhosts-cli
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ORG and REPOPATH do not seem to be used

@praveenkumar
Copy link
Member Author

Would be good to have a link to the upstream PR
@cfergeau goodhosts#4

Makefile Outdated

# Add default target
.PHONY: default
default: install
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is more usual than default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@praveenkumar praveenkumar merged commit 2fc9120 into crc-org:master Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants