fix: logo change for verifier login #1254
Merged
+58
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to e0a36b5 in 7 minutes and 13 seconds. Click for details.
- Reviewed
62lines of code in1files - Skipped
2files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/features/components/sigin-view.tsx:30
- Draft comment:
The comparison against 'VERIFIER' is case sensitive. Consider normalizing the alias (e.g., using toUpperCase) for more robust matching. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% This is a UI feature that changes the logo based on a query parameter. While case-insensitive matching might be more forgiving, there's no strong evidence that this is actually a problem. The expected value 'VERIFIER' could be part of a contract or specification. Without knowing the broader system context or requirements, we can't be certain this needs to be changed. The comment raises a valid software engineering practice, but we don't know if case-sensitivity is actually a requirement here. The current code might be working exactly as intended. Given that this is a UI feature and the value appears to be a fixed constant, the current implementation could be intentional and working correctly in production. The comment should be removed as it makes assumptions about requirements without strong evidence that case-sensitivity is a problem.
2. src/features/components/sigin-view.tsx:52
- Draft comment:
For better accessibility, update the alt text to reflect the actual logo (e.g., 'Verifier Logo') when clientAlias is 'VERIFIER'. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_2pcEAJTEArFZOqmD
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed b9a1dd1 in 45 seconds. Click for details.
- Reviewed
17lines of code in1files - Skipped
2files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/features/components/sigin-view.tsx:37
- Draft comment:
Consider refactoring duplicated logo assignment logic; also verify that the hardcoded alias 'EDUCREDS' and its logo paths (using .svg) align with expected naming conventions and the case-sensitivity of the query parameter. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
Workflow ID: wflow_QLUUI3liyCztBW4g
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 78a273c in 1 minute and 54 seconds. Click for details.
- Reviewed
23lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/features/components/sigin-view.tsx:34
- Draft comment:
Ensure NEXT_PUBLIC_LOGO_BASE_URL includes a trailing slash; otherwise URL concatenation (e.g. '${process.env.NEXT_PUBLIC_LOGO_BASE_URL}${alias}_logo_dark.svg') may be incorrect. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The comment starts with "Ensure that..." which is a red flag per our rules. It's asking the author to verify something rather than pointing out a definite issue. We don't know if NEXT_PUBLIC_LOGO_BASE_URL already has a trailing slash in the environment config. This is more of a speculative "what if" comment rather than pointing out a clear problem. The comment does raise a valid concern about URL construction. Missing slashes in URLs can cause real problems. While URL construction is important, this comment is speculative and asks for verification rather than pointing out a definite issue. We don't have evidence that this is actually a problem. Delete the comment. It violates our rules by being speculative and asking for verification rather than pointing out a definite issue.
2. src/features/components/sigin-view.tsx:35
- Draft comment:
Verify asset naming and format: The VERIFIER dark logo changed from PNG ('/logos/verifier_logo_dark.png') to SVG (using '${alias}_logo_dark.svg'); also EDUCREDS now uses dynamic naming. Confirm these changes match your asset files. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. src/features/components/sigin-view.tsx:40
- Draft comment:
Ensure the clientAlias (used as 'alias') is sanitized/validated before using it in the logo URL to prevent potential misuse or broken asset paths. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_4jH5ebMCQEgGom2D
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 4f62cc7 in 41 seconds. Click for details.
- Reviewed
36lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/features/components/sigin-view.tsx:30
- Draft comment:
The new if(alias) block now accepts any alias, unlike the previous explicit cases. Confirm that allowing arbitrary alias values is intended. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src/features/components/sigin-view.tsx:31
- Draft comment:
Ensure NEXT_PUBLIC_LOGO_BASE_URL has a trailing slash to prevent URL concatenation issues. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_GToiGRa5pMx2coth
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 9fd3cba in 48 seconds. Click for details.
- Reviewed
247lines of code in6files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/app/api/Auth.ts:78
- Draft comment:
Add optional 'clientAlias' parameter to forgotPassword payload for verifier-specific behavior. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/app/reset-password/ResetPassword.tsx:87
- Draft comment:
Refactor logo rendering by replacing static Image with DynamicLogo for consistent theming. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/features/components/DynamicLogo.tsx:34
- Draft comment:
Good dynamic logo logic; consider validating NEXT_PUBLIC_LOGO_BASE_URL to guard against undefined values. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. src/features/components/SignUpViewPage.tsx:17
- Draft comment:
Replacing the static logo with DynamicLogo ensures consistent branding across pages. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. src/features/components/sigin-view.tsx:18
- Draft comment:
DynamicLogo integration here improves maintainability over using static image paths. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. src/features/components/user-auth-form.tsx:263
- Draft comment:
Pass 'clientAlias' from search params to forgotPassword API call to support verifier-specific branding. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_ktVytoICQDyBfx7P
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Skipped PR review on ce5f8d4 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed a61301a in 1 minute and 2 seconds. Click for details.
- Reviewed
83lines of code in4files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/app/reset-password/ResetPassword.tsx:18
- Draft comment:
DynamicApplicationLogo import is updated correctly. Ensure consistent branding across pages. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure something, which violates the rule against asking the author to ensure behavior. It doesn't provide a specific suggestion or point out a specific issue in the code.
2. src/features/components/DynamicLogo.tsx:8
- Draft comment:
Component renamed to DynamicApplicationLogo—consider renaming the file for coherence. - Reason this comment was not posted:
Comment was on unchanged code.
3. src/features/components/SignUpViewPage.tsx:3
- Draft comment:
Usage of DynamicApplicationLogo is consistent with the new logo component name. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states that the usage is consistent, which does not help the PR author improve the code.
4. src/features/components/sigin-view.tsx:3
- Draft comment:
DynamicApplicationLogo is used correctly here, ensuring consistency with other auth pages. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only states that something is used correctly without providing any actionable feedback or suggestions for improvement.
Workflow ID: wflow_Gjwu569LCTytc8K4
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
shitrerohit
approved these changes
Oct 17, 2025
a61301a to
7cc33fc
Compare
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 7cc33fc in 1 minute and 19 seconds. Click for details.
- Reviewed
98lines of code in5files - Skipped
0files when reviewing. - Skipped posting
10draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .env.demo:35
- Draft comment:
Added NEXT_PUBLIC_LOGO_BASE_URL variable; consider providing a default value or a note to ensure it ends with a trailing slash. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src/app/reset-password/ResetPassword.tsx:18
- Draft comment:
Replaced DynamicLogo import with DynamicApplicationLogo for clarity and consistency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/app/reset-password/ResetPassword.tsx:87
- Draft comment:
Updated logo component usage to DynamicApplicationLogo to match the updated import. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. src/features/components/DynamicLogo.tsx:8
- Draft comment:
Renamed component to DynamicApplicationLogo; ensure the component name and file usage remain consistent across the project. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. src/features/components/DynamicLogo.tsx:20
- Draft comment:
When using process.env.NEXT_PUBLIC_LOGO_BASE_URL with alias, ensure the URL ends with a trailing slash to avoid broken image paths. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
6. src/features/components/DynamicLogo.tsx:44
- Draft comment:
Updated export default to DynamicApplicationLogo after the component renaming. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. src/features/components/SignUpViewPage.tsx:3
- Draft comment:
Updated import to DynamicApplicationLogo for consistent branding. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
8. src/features/components/SignUpViewPage.tsx:17
- Draft comment:
Using DynamicApplicationLogo ensures consistent logo display in the layout. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
9. src/features/components/sigin-view.tsx:3
- Draft comment:
Updated import to DynamicApplicationLogo for uniform branding. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
10. src/features/components/sigin-view.tsx:18
- Draft comment:
Ensured use of DynamicApplicationLogo for consistent logo display on the sign-in page. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_6fbJ8bPi2r0V2fFD
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
7cc33fc to
393fe12
Compare
Signed-off-by: sujitaw <[email protected]> Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: sujitaw <[email protected]> Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: sujitaw <[email protected]> Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: sujitaw <[email protected]> Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: sujitaw <[email protected]> Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: sujitaw <[email protected]> Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: sujitaw <[email protected]> Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: sujitaw <[email protected]> Signed-off-by: pranalidhanavade <[email protected]>
393fe12 to
172e7bc
Compare
GHkrishna
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Important
Introduces dynamic logo loading for verifier login using
DynamicApplicationLogocomponent, updating several components and adding environment configuration.DynamicApplicationLogocomponent inDynamicLogo.tsxto dynamically load logos based onclientAliasand theme.ResetPassword.tsx,SignUpViewPage.tsx, andsigin-view.tsxto useDynamicApplicationLogoinstead of static logo imports.clientAliasparameter toforgotPasswordfunction inAuth.tsto support dynamic logo loading.NEXT_PUBLIC_LOGO_BASE_URLto.env.demofor dynamic logo URL configuration.This description was created by
for 7cc33fc. You can customize this summary. It will automatically update as commits are pushed.