Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: helper.bats functions 'create_runtime_with_allowed_annotation' is not taken into account #6175

@littlejawa

Description

@littlejawa

What happened?

When running the tests for the kata runtime, all tests using the create_runtime_with_allowed_annotation function from helpers.bats are failing.

This function creates a crio.conf file with a specific runtime using RUNTIME_BINARY_PATH, RUNTIME_ROOT and RUNTIME_TYPE env variables, plus specified allowed annotations, and set this runtime as default.
In theory, this should make sure that whatever runtime being used for the test would just be used with the added annotations.

In practice, if the default runtime is specified with the CONTAINER_DEFAULT_RUNTIME env variable, this takes precedence over the conf file, and the configuration set by create_runtime_with_allowed_annotation is ignored.

What did you expect to happen?

Running the tests with added annotations in a reliable way, with the kata runtime.

How can we reproduce it (as minimally and precisely as possible)?

Enable any of the following tests and run them with the kata runtime:

  • devices.bats (all tests with annotations)
  • shm_size.bats
  • workload.bats (several tests related to annotations)

Anything else we need to know?

No response

CRI-O and Kubernetes version

Details Irrelevant - this is a test script issue

OS version

Details Irrelevant - this is a test script issue

Additional environment details (AWS, VirtualBox, physical, etc.)

Details

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions