-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
What happened?
When running the tests for the kata runtime, all tests using the create_runtime_with_allowed_annotation function from helpers.bats are failing.
This function creates a crio.conf file with a specific runtime using RUNTIME_BINARY_PATH, RUNTIME_ROOT and RUNTIME_TYPE env variables, plus specified allowed annotations, and set this runtime as default.
In theory, this should make sure that whatever runtime being used for the test would just be used with the added annotations.
In practice, if the default runtime is specified with the CONTAINER_DEFAULT_RUNTIME env variable, this takes precedence over the conf file, and the configuration set by create_runtime_with_allowed_annotation is ignored.
What did you expect to happen?
Running the tests with added annotations in a reliable way, with the kata runtime.
How can we reproduce it (as minimally and precisely as possible)?
Enable any of the following tests and run them with the kata runtime:
- devices.bats (all tests with annotations)
- shm_size.bats
- workload.bats (several tests related to annotations)
Anything else we need to know?
No response