Thanks to visit codestin.com
Credit goes to github.com

Skip to content

utils: delete unused code #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
runcom merged 1 commit into from
Mar 9, 2018
Merged

utils: delete unused code #1411

runcom merged 1 commit into from
Mar 9, 2018

Conversation

@vbatts
Copy link
Contributor

@vbatts vbatts commented Mar 2, 2018 •
edited
Loading

This began as shuffling platform dependent code, but none of the functions were even used. This just removes it instead.
Still cross-platform ;-)

- What I did

- How I did it

- How to verify it

- Description for the changelog

@vbatts vbatts requested review from mrunalp and runcom as code owners March 2, 2018 19:33
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2018
@vbatts
Copy link
Contributor Author

vbatts commented Mar 6, 2018

rebased

@wking
Copy link
Contributor

wking commented Mar 6, 2018

None of these functions are used anywhere outside of the code you're touching, with the last GetDeviceNameFromPath consumer dropped in 5f7ac28 (#1324). Instead of splitting these into Linux/Windows implementations, can we just drop them?

@vbatts
Copy link
Contributor Author

vbatts commented Mar 6, 2018

@wking i wondered about that. @doublerainbo added them in bfaf35b
Not sure if there were future plans?

@vbatts
Copy link
Contributor Author

vbatts commented Mar 8, 2018

fixed lint. PTAL

@rhatdan
Copy link
Contributor

rhatdan commented Mar 8, 2018

LGTM
/test all

vbatts added a commit to vbatts/cri-o that referenced this pull request Mar 8, 2018
@vbatts
utils: platform independent calls
72af673 
cri-o#1411

Signed-off-by: Vincent Batts <[email protected]>

utils: isolate unix only functions

Signed-off-by: Vincent Batts <[email protected]>
@vbatts
Copy link
Contributor Author

vbatts commented Mar 8, 2018

/test integration_rhel

1 similar comment
@vbatts
Copy link
Contributor Author

vbatts commented Mar 8, 2018

/test integration_rhel

vbatts added a commit to vbatts/cri-o that referenced this pull request Mar 8, 2018
@vbatts
utils: platform independent calls
24cbf12 
cri-o#1411

Signed-off-by: Vincent Batts <[email protected]>

utils: isolate unix only functions

Signed-off-by: Vincent Batts <[email protected]>
vbatts added a commit to vbatts/cri-o that referenced this pull request Mar 8, 2018
@vbatts
utils: platform independent calls
88de477 
cri-o#1411

Signed-off-by: Vincent Batts <[email protected]>

utils: isolate unix only functions

Signed-off-by: Vincent Batts <[email protected]>
vbatts added a commit to vbatts/cri-o that referenced this pull request Mar 8, 2018
@vbatts
utils: platform independent calls
16a0612 
cri-o#1411

Signed-off-by: Vincent Batts <[email protected]>

utils: isolate unix only functions

Signed-off-by: Vincent Batts <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 8, 2018

@vbatts: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_rhel 151eb6c link /test integration_rhel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Contributor

wking commented Mar 8, 2018

I'm still in favor of just dropping these unused functions, in case we want to pivot to that approach before banging away on integration_rhel ;).

@vbatts
utils: delete unused code
f616ad7 
This began as shuffling platform dependent code, but none of the
functions were even used. This just removes it instead.
Still cross-platform ;-)

Signed-off-by: Vincent Batts <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2018
@vbatts vbatts changed the title utils: cross-platform changes utils: delete unused code Mar 9, 2018
@vbatts
Copy link
Contributor Author

vbatts commented Mar 9, 2018

i got out the axe 🔪 ...

@vbatts
Copy link
Contributor Author

vbatts commented Mar 9, 2018

all green. PTAL

@rhatdan
Copy link
Contributor

rhatdan commented Mar 9, 2018

I don't think we need to run the e2e tests if this compiles.
LGTM

@runcom
Copy link
Member

runcom commented Mar 9, 2018

LGTM

@runcom runcom merged commit 3790882 into cri-o:master Mar 9, 2018
@vbatts vbatts deleted the platform-008 branch March 9, 2018 18:34
@vbatts vbatts mentioned this pull request Jun 5, 2018
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vbatts @wking @rhatdan @openshift-ci-robot @runcom @k8s-ci-robot