Make image APIs return empty struct instead of nil #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mrunal Patel <[email protected]>
Member
Author
Member
|
LGTM |
Member
|
Oh, this is already fixed in #28 (I forgot it) |
Member
Author
Contributor
Member
|
Sure |
Member
Author
|
Can we get this in while we wait for #28 to land?
|
Member
|
Isn't it already in? |
egernst
pushed a commit
to egernst/cri-o
that referenced
this pull request
Nov 26, 2018
Fix image generation. Instead of use agent code from the host checkout to the agent source code in a clean GOPATH env. Make sure that the agent `commit id` is the correct before push to github or OBS. Fixes: cri-o#166 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocid crashes under kubelet immediately as it can't marshal nil. This PR fixes that by returning empty structs instead of nil and also adds debugs.
Signed-off-by: Mrunal Patel [email protected]