Fix install of unit file and configuration file #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Walsh <[email protected]>
Contributor
Author
|
Sorry these are still broken. The ocid.config file is being installed in /usr/etc/ocid.conf and the systemd unit file was being created as the directory name. |
Member
|
LGTM |
Contributor
|
IMO |
Contributor
Author
|
Sure, if this is installed in different directories in different distributions. |
Contributor
Author
|
I was also debating removing this altogether from the Makefile and moving it to contrib/systemd/Makefile. |
egernst
pushed a commit
to egernst/cri-o
that referenced
this pull request
Nov 26, 2018
snap: fix snapcraft.yaml for kata-container 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Walsh [email protected]