Add "image list/remove/status" to the client #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "image list", "image status", and "image remove" subcommands to the client. Signed-off-by: Nalin Dahyabhai <[email protected]>
Member
|
I'm ok with this if this will ease the work in #28 |
Collaborator
Author
|
It's probably going to be needed for integration testing, though at the moment I have no such tests written. |
Contributor
|
@runcom if the code looks ok, we can just add a comment that we need someone to write tests for it. |
Collaborator
Author
|
I can work up a few, but they're going to have to wait for #28, where we're going to be fleshing out the server stubs. |
Contributor
|
So we have a chicken and egg then. We need this patch to be merged to make merging #28 easier, and then we can additional tests for this patch? |
Collaborator
Author
|
The main benefit is that it's this many lines of code that we won't have to review as part of a larger PR for #28. |
Member
|
No objections getting this in. But we should add tests when for the server changes when they are ready. |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
egernst
pushed a commit
to egernst/cri-o
that referenced
this pull request
Nov 26, 2018
packaging: Replace `-` for `~`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds "image list", "image status", and "image remove" subcommands to the client, most of it boilerplate stuff.