Skip lint on vendored code #216
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mrunal Patel <[email protected]>
Member
|
@mrunalp just wondering why this check https://github.com/kubernetes-incubator/cri-o/pull/216/files#diff-83d106fb4efabf167e2d62a14cc83739R7 isn't working |
Member
Author
|
@runcom Is it because the checks are originating from our code but following imports into vendor? |
Member
|
@mrunalp weird, it may be though. I guess this fix is valid though. Feel free to merge it. |
egernst
pushed a commit
to egernst/cri-o
that referenced
this pull request
Nov 26, 2018
The spec-template file looks for x86 specific files irrespective of the arch on which packaging is done for. Fixes: cri-o#216 Signed-off-by: Nitesh Konkar [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@runcom PTAL
Signed-off-by: Mrunal Patel [email protected]