*: add seccomp buildtag #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Murdaca <[email protected]>
Contributor
|
LGTM |
wking
added a commit
to wking/cri-o
that referenced
this pull request
Mar 8, 2018
We've been hardcoding it since 0e4af6d (*: add seccomp buildtag, 2016-11-29, cri-o#219), but that predates the hack/* approach which landed in f893e38 (Add build tags for integration tests, 2016-12-07, cri-o#210). I'm not sure why cri-o#210 skipped libseccomp (possibly because we always install it on Linux in .travis.yml), but now that we are trying to build on OS X too we need to be more flexible.
wking
added a commit
to wking/cri-o
that referenced
this pull request
Mar 8, 2018
We've been hardcoding it since 0e4af6d (*: add seccomp buildtag, 2016-11-29, cri-o#219), but that predates the hack/* approach which landed in f893e38 (Add build tags for integration tests, 2016-12-07, cri-o#210). I'm not sure why cri-o#210 skipped libseccomp (possibly because we always install it on Linux in .travis.yml), but now that we are trying to build on OS X too we need to be more flexible. Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #218
@mrunalp @Crazykev PTAL
Signed-off-by: Antonio Murdaca [email protected]