Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mrunalp
Copy link
Member

@mrunalp mrunalp commented Dec 13, 2016

@runcom @sameo PTAL. See if this helps with races during tests.

Signed-off-by: Mrunal Patel [email protected]

@runcom
Copy link
Member

runcom commented Dec 13, 2016

@feiskyer @jjlakis PTAL as well when integrating k8s

@runcom
Copy link
Member

runcom commented Dec 14, 2016

BTW, tests still fails with wait: no child processes for instance https://paste.fedoraproject.org/506082/

# time="2016-12-14T10:25:31+01:00" level=fatal msg="listing pod sandboxes failed: rpc error: code = 2 desc = error getting container state for redhat.test.ocid-podsandbox1-1-infra: wait: no child processes
[...]

I believe ignoring ECHILD (as done in #269) is bad, I'm trying to sync everything not to get that rather (or to better filter it)

@Crazykev
Copy link
Contributor

@runcom I don't think this kind of race could be solved in ocid by adding lock like this way, this maybe a problem that we did't use cmd.Run/Start/Wait correctly.

@runcom
Copy link
Member

runcom commented Dec 14, 2016

@runcom I don't think this kind of race could be solved in ocid by adding lock like this way, this maybe a problem that we did't use cmd.Run/Start/Wait correctly.

right, indeed, we're still getting that error - ignoring it like that isn't really helping either

@Crazykev
Copy link
Contributor

@runcom Yep,I forgot add a warning for that, and sure that's not a long term solution, just make sure it won't block our way on testing or running. I'm also finding a way to fix that.

@runcom
Copy link
Member

runcom commented Dec 14, 2016

I believe having a container operation lock makes sense anyway, going to merge this one as it won't likely cause any issue as is.

@runcom runcom merged commit c9dcea4 into cri-o:master Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants